Skip to content

Fix ResponseCompression tests to work with different zlib implementations #63988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ResponseCompression tests to work with different zlib implementations #63988

wants to merge 1 commit into from
+73 −4

Conversation

medhatiwari
Copy link
Contributor

Fix ResponseCompression tests for system zlib compatibility

Fixes #63969

Changes

  • Replace exact byte count assertions with functional decompression verification in CheckResponseCompressed
  • Add CheckCompressionFunctionality method to verify compression by decompressing content
  • Update HTTPS test methods to use appropriate verification based on compression state
  • Handle edge cases: HEAD requests, NoCompression, and SendFileAsync scenarios

Testing

All existing tests pass with both zlib-ng and system zlib implementations.

cc: @giritrivedi

@github-actions github-actions bot added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Oct 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 10, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @@medhatiwari. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ResponseCompression tests should verify functionality, not exact compressed byte counts

1 participant

@medhatiwari